fix(core): enable stashing only when withEventReplay() is invoked
#61077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndrewKushnir this is what we've discussed in this PR (#59635 (comment)). |
There was a problem hiding this comment.
@arturovt thanks for the PR 👍
The change looks good, one quick comment: I think we should move this logic to an event-replay-related file, for ex. event_delegation_utils.ts, so the code is colocated with the rest of the event replay logic. We can also move the setStashFn and related logic (introduced in a previous PR) there too.
8f7d01f to
fef790b
Compare
This commit brings the necessary event replay code code in tree-shakable manner.
fef790b to
f2fc8fd
Compare
AndrewKushnir
approved these changes
May 8, 2025
|
Caretaker note: the presubmit is "green" (only unrelated and pre-existing failures). |
|
This PR was merged into the repository by commit a5db6c4. The changes were merged into the following branches: main, 20.0.x |
arturovt
added a commit
to arturovt/angular
that referenced
this pull request
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings the necessary event replay code code in tree-shakable manner.