refactor(devtools): introduce responsive-split directive #61204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkgs
commented
May 8, 2025
| display: block; | ||
| } | ||
|
|
||
| :host { |
There was a problem hiding this comment.
It seems that a lot of the CSS in this file is no longer used/relevant.
101bbc2 to
cd59391
Compare
JeanMeche
reviewed
May 8, 2025
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Outdated
Show resolved
Hide resolved
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Show resolved
Hide resolved
e95eb14 to
98c821f
Compare
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Outdated
Show resolved
Hide resolved
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Outdated
Show resolved
Hide resolved
468f03d to
8c4f148
Compare
|
@AleksanderBodurri, I went with the flat config structure. I've added a more descriptive TSDoc comments that should, hopefully, clarify which direction is activated by the ratio and under which conditions. |
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Show resolved
Hide resolved
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Outdated
Show resolved
Hide resolved
8c4f148 to
fa85b1c
Compare
AleksanderBodurri
approved these changes
May 12, 2025
The `ResponsiveSplitDirective` adds responsive behavior to the `as-split` component by a provided width to height ratio.
fa85b1c to
2761487
Compare
Run window:resize outside of Angular.
2761487 to
9f42d58
Compare
|
Tests are now passing successfully. |
|
This PR was merged into the repository by commit f5c67f1. The changes were merged into the following branches: main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
The
ResponsiveSplitDirectiveadds responsive behavior to theas-splitcomponent by a provided width to height ratio. It's now employed by the Injector Tree tab.Needed for #60478 as well.
cc @dgp1130
Does this PR introduce a breaking change?