Initial language service support for selectorless #61240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
approved these changes
May 12, 2025
| if (meta !== null && meta.selector !== null) { | ||
| const ref = new Reference<ClassDeclaration>(symbol.tsSymbol.valueDeclaration as any); | ||
| // Host directives will be added as identifiers with the same offset as the host | ||
| // which means that they'll get added twice. De-duplicate them to avoid confusion. |
There was a problem hiding this comment.
out of curiosity, is this new or why is this surfacing now?
There was a problem hiding this comment.
It was always like that, we just didn't have any tests with host directives so we never noticed it. I think that also the language service integration was de-duping the information produced as a result at some point so it didn't affect users either.
| /** | ||
| * A `TmplAstComponent` element node that's targeted, where the given position is within the body. | ||
| */ | ||
| export interface ComponentInBodyContext { |
There was a problem hiding this comment.
I know this is not new, but "body" was confusing me for a bit.
The template symbol builder works by finding the variables referring to template AST nodes with specific offsets and resolving them to directives. Afterwards it goes through the directives and resolves their host directives. The problem is that host directives are added with the exact same offsets as their host which means they get added once initially and again when resolving host directives. These changes resolve the issue by de-duplicating them.
Updates the template type checker to produce symbols for selectorless nodes. This is necessary for integration into the language service.
Adds the logic to resolve the template targets for the selectorless component and directive nodes. This is a prerequisite for other functionality.
Updates the language service to handle producing definition information for selectorless components and directives.
Updates the language service to produce quick info for selectorless components and directives.
…on for selectorless Adds an initial implementation for finding references and renaming to selectorless components/directives. Finding references should work everywhere, whereas renaming only currently works when initiated from the template.
f6858dc to
2580eda
Compare
devversion
approved these changes
May 12, 2025
|
This PR was merged into the repository by commit fa27b76. The changes were merged into the following branches: main |
alxhub
pushed a commit
that referenced
this pull request
May 12, 2025
) Updates the language service to handle producing definition information for selectorless components and directives. PR Close #61240
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
May 13, 2025
Follow-up from angular#61240 (comment). Adds a `isSelfClosing` property on element-like AST nodes so consumers can easily determine if it's self-closing, rather than having to look at the spans. This is useful for migrations and in the language service.
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
May 13, 2025
…ectives Follow-up to angular#61240 that adds renaming support for selectorless components/directives both from the template and from the TypeScript source.
crisbeto
added a commit
that referenced
this pull request
May 14, 2025
Follow-up from #61240 (comment). Adds a `isSelfClosing` property on element-like AST nodes so consumers can easily determine if it's self-closing, rather than having to look at the spans. This is useful for migrations and in the language service. PR Close #61307
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up some initial support for selectorless in the language service which handles things like resolving definitions and hover tooltips. We're still missing at least the following:
Includes the following changes:
fix(compiler-cli): symbol builder duplicating host directives
The template symbol builder works by finding the variables referring to template AST nodes with specific offsets and resolving them to directives. Afterwards it goes through the directives and resolves their host directives.
The problem is that host directives are added with the exact same offsets as their host which means they get added once initially and again when resolving host directives.
These changes resolve the issue by de-duplicating them.
refactor(compiler-cli): produce template symbols for selectorless nodes
Updates the template type checker to produce symbols for selectorless nodes. This is necessary for integration into the language service.
refactor(language-service): set up template targets for selectorless
Adds the logic to resolve the template targets for the selectorless component and directive nodes. This is a prerequisite for other functionality.
refactor(language-service): support definitions for selectorless
Updates the language service to handle producing definition information for selectorless components and directives.
refactor(language-service): support quick info selectorless symbols
Updates the language service to produce quick info for selectorless components and directives.
refactor(language-service): initial reference and rename implementation for selectorless
Adds an initial implementation for finding references and renaming to selectorless components/directives.
Finding references should work everywhere, whereas renaming only currently works when initiated from the template.