Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(core): TestBed.tick should ensure test components are synchronized #61382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(core): TestBed.tick should ensure test components are synchronized #61382

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented May 16, 2025

This ensures that TestBed.tick updates any components created with TestBed.createComponent, regardless of whether autoDetectChanges is on.

@atscott atscott added the target: rc This PR is targeted for the next release-candidate label May 16, 2025
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label May 16, 2025
@ngbot ngbot bot added this to the Backlog milestone May 16, 2025
@atscott atscott mentioned this pull request May 16, 2025
Draft
@atscott atscott marked this pull request as ready for review May 19, 2025 17:37
@atscott atscott modified the milestones: Backlog, v20 candidates May 19, 2025
pkozlowski-opensource
pkozlowski-opensource approved these changes May 21, 2025
View reviewed changes
@pkozlowski-opensource pkozlowski-opensource added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 21, 2025
@pkozlowski-opensource
Copy link
Member

This will need cleanup as there is a test reporting size increase. It is not clear to me if this is linked to this change or we've just accumulated changes over time :-/ (and our infra is not helping here...)

@atscott
Copy link
Contributor Author

atscott commented May 21, 2025

@pkozlowski-opensource PTAL. Size tracking was unrelated and updated in https://github.com/angular/angular/pull/61261/files

@atscott
fix(core): TestBed.tick should ensure test components are synchronized
538f04f 
This ensures that `TestBed.tick` updates any components created with
`TestBed.createComponent`, regardless of whether autoDetectChanges is
on.
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 21, 2025
thePunderWoman pushed a commit that referenced this pull request May 21, 2025
@atscott @thePunderWoman
fix(core): TestBed.tick should ensure test components are synchronized (
350776b 
#61382)

This ensures that `TestBed.tick` updates any components created with
`TestBed.createComponent`, regardless of whether autoDetectChanges is
on.

PR Close #61382
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 971981e.

The changes were merged into the following branches: main, 20.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
v20 candidates
Development

Successfully merging this pull request may close these issues.
3 participants
@atscott @pkozlowski-opensource @thePunderWoman