feat(compiler-cli): support host directives with direct external references in fast type declaration emission #61469
+385
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e7865c to
9428d3b
Compare
…rences in fast type declaration emission In the initial implementation for experimental fast type declaration emission introduced in e62fb35, external references in host directives were not supported at all. This change adds support for direct external references in host directives. Any other expressions indirectly using external references are still not supported.
9428d3b to
552f871
Compare
devversion
approved these changes
May 21, 2025
This comment was marked as outdated.
This comment was marked as outdated.
|
This PR was merged into the repository by commit 0cf1001. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
External references in host directives are not supported at all in the initial implementation for experimental fast type declaration emission introduced in e62fb35.
What is the new behavior?
Direct external references in host directives are supported in experimental fast type declaration emission, likely covering the majority of cases as using other expressions to define host directives seems to be the exception.
Does this PR introduce a breaking change?