Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(devtools): add dagre-d3-es to prepare for the signal graph #61538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(devtools): add dagre-d3-es to prepare for the signal graph #61538

wants to merge 1 commit into from

Conversation

milomg
Copy link
Contributor

@milomg milomg commented May 20, 2025 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

I've installed dagre-d3-es as a new package for use in devtools.

This is the most popular fork of dagre, which still doesn't work with esm (and therefore is harder to integrate into our build pipeline). Dagre will allow us to layout the signals visualization in a compact graph

See #60478 for a more complete demo

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: devtools labels May 20, 2025
@ngbot ngbot bot added this to the Backlog milestone May 20, 2025
@milomg milomg changed the title feat(devtools): Prepare to add signal graph feat(devtools): add dagre-d3-es to prepare for the signal graph May 20, 2025
@milomg milomg marked this pull request as ready for review May 20, 2025 21:00
@pullapprove pullapprove bot requested a review from josephperrott May 20, 2025 21:00
josephperrott
josephperrott approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche
Copy link
Member

Can the commit message maybe include why we're patching the lib ?

@milomg
Copy link
Contributor Author

milomg commented May 21, 2025

@JeanMeche Is this what you were thinking of?

Additionally, add a patch so that html labels display correctly within d3-zoom

@JeanMeche
Copy link
Member

🤦‍♂️ My bad, yes.

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 21, 2025
@milomg
refactor(devtools): add dagre-d3-es
07ef112 
add dagre-d3-es for use by the signals graph pane. Additionally, add a
patch so that html labels display correctly within d3-zoom
@angular-robot angular-robot bot requested a review from JeanMeche May 21, 2025 00:40
@JeanMeche JeanMeche added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels May 21, 2025
@JeanMeche
Copy link
Member

The PR doesn't merge properly into main, we'll target minor and discuss if we want to backport it on the v20.0 branch.

@JeanMeche JeanMeche added target: rc This PR is targeted for the next release-candidate target: minor This PR is targeted for the next minor release and removed target: minor This PR is targeted for the next minor release target: rc This PR is targeted for the next release-candidate labels May 21, 2025
@thePunderWoman thePunderWoman changed the title feat(devtools): add dagre-d3-es to prepare for the signal graph refactor(devtools): add dagre-d3-es to prepare for the signal graph May 21, 2025
@thePunderWoman thePunderWoman removed the detected: feature PR contains a feature commit label May 21, 2025
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 33715b0.

The changes were merged into the following branches: main

@milomg milomg deleted the signal-graph-1 branch May 22, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: devtools target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@milomg @JeanMeche @thePunderWoman @josephperrott