Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(devtools): add button component #61549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(devtools): add button component #61549

wants to merge 1 commit into from
+135 −0

Conversation

milomg
Copy link
Contributor

@milomg milomg commented May 21, 2025 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Add a new button component (written by @hawkgs here milomg#1, I'm just copying it over to the main repo) for use in the signals graph visualizer. This PR is part of #60478

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from AleksanderBodurri May 21, 2025 02:05
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: devtools labels May 21, 2025
@ngbot ngbot bot added this to the Backlog milestone May 21, 2025
@JeanMeche
Copy link
Member

Can you please check the linting issue 👍

@milomg
feat(devtools): add button component
dd3e468 
enables flexible styling of button components with ng-button attribute
@milomg milomg force-pushed the signal-graph-button branch from 9433fdf to dd3e468 Compare June 3, 2025 05:53
@thePunderWoman thePunderWoman added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jun 5, 2025
@thePunderWoman thePunderWoman removed the request for review from AleksanderBodurri June 5, 2025 07:42
@pkozlowski-opensource pkozlowski-opensource added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 5, 2025
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 8e861ef.

The changes were merged into the following branches: main

@milomg milomg deleted the signal-graph-button branch June 6, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkgs hawkgs hawkgs left review comments

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: devtools detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@milomg @JeanMeche @pkozlowski-opensource @hawkgs @thePunderWoman