fix(migrations): preserve comments when removing unused imports #61674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the unused imports schematic to preserve comments inside the array. THis is necessary for some internal use cases.
devversion
approved these changes
May 26, 2025
thePunderWoman
pushed a commit
that referenced
this pull request
May 26, 2025
Updates the unused imports schematic to preserve comments inside the array. THis is necessary for some internal use cases. PR Close #61674
thePunderWoman
pushed a commit
that referenced
this pull request
May 26, 2025
Updates the unused imports schematic to preserve comments inside the array. THis is necessary for some internal use cases. PR Close #61674
|
This PR was merged into the repository by commit 04656d0. The changes were merged into the following branches: main, 19.2.x, 20.0.x |
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
May 27, 2025
Follow-up to angular#61674 where we were leaving behind some whitespace, e.g. `[One, Two, Three]` would turn into `[One ]`. These changes only preserve the whitespace if the node is preceded by a newline. This wasn't caught by tests, because they were stripping away whitespaces before asserting. I've also reworked the tests to be sensitive to formatting changes.
kirjs
pushed a commit
that referenced
this pull request
May 30, 2025
…on (#61698) Follow-up to #61674 where we were leaving behind some whitespace, e.g. `[One, Two, Three]` would turn into `[One ]`. These changes only preserve the whitespace if the node is preceded by a newline. This wasn't caught by tests, because they were stripping away whitespaces before asserting. I've also reworked the tests to be sensitive to formatting changes. PR Close #61698
kirjs
pushed a commit
that referenced
this pull request
May 30, 2025
…on (#61698) Follow-up to #61674 where we were leaving behind some whitespace, e.g. `[One, Two, Three]` would turn into `[One ]`. These changes only preserve the whitespace if the node is preceded by a newline. This wasn't caught by tests, because they were stripping away whitespaces before asserting. I've also reworked the tests to be sensitive to formatting changes. PR Close #61698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the unused imports schematic to preserve comments inside the array. THis is necessary for some internal use cases.