Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(core): unregister onDestroy in ResourceImpl when destroy() is called #61870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(core): unregister onDestroy in ResourceImpl when destroy() is called #61870

wants to merge 1 commit into from

Conversation

arturovt
Copy link
Contributor

@arturovt arturovt commented Jun 4, 2025

This commit unregisters the onDestroy listener when destroy() is called on the ResourceImpl. This prevents memory leaks and ensures that the resource reference is not captured in the destroy callback after it has already been destroyed.

@arturovt
fix(core): unregister onDestroy in ResourceImpl when destroy() …
ea2f6e6 
…is called

This commit unregisters the `onDestroy` listener when `destroy()` is called on the `ResourceImpl`. This prevents memory leaks and ensures that the resource reference is not captured in the destroy callback after it has already been destroyed.
@pullapprove pullapprove bot requested a review from thePunderWoman June 4, 2025 14:59
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jun 4, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 4, 2025
@thePunderWoman thePunderWoman requested review from alxhub and atscott and removed request for thePunderWoman June 4, 2025 15:03
thePunderWoman
thePunderWoman approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 4, 2025
@kirjs
Copy link
Contributor

kirjs commented Jun 4, 2025

This PR was merged into the repository by commit 080b368.

The changes were merged into the following branches: main, 20.0.x

kirjs pushed a commit that referenced this pull request Jun 4, 2025
@arturovt @kirjs
fix(core): unregister onDestroy in ResourceImpl when destroy() …
ddd22be 
…is called (#61870)

This commit unregisters the `onDestroy` listener when `destroy()` is called on the `ResourceImpl`. This prevents memory leaks and ensures that the resource reference is not captured in the destroy callback after it has already been destroyed.

PR Close #61870
@kirjs kirjs closed this in 080b368 Jun 4, 2025
@arturovt arturovt deleted the fix/core-resource-unregister branch June 4, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@arturovt @kirjs @JeanMeche @thePunderWoman