Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(devtools): create devtools signals view #61919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(devtools): create devtools signals view #61919

wants to merge 1 commit into from

Conversation

milomg
Copy link
Contributor

@milomg milomg commented Jun 6, 2025 •
edited
Loading

create a component for the devtools signal pane, including view source, view value, and flashing of node updates

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Blocked on #61917, #61918

See #60478 for a more complete demo

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: devtools labels Jun 6, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 6, 2025
@milomg milomg force-pushed the signal-graph-8 branch 2 times, most recently from 8a32ab1 to 66ebbb2 Compare June 6, 2025 22:39
@milomg milomg marked this pull request as ready for review June 6, 2025 22:40
@hawkgs
Copy link
Member

hawkgs commented Jun 9, 2025

Looks good! ✨ Left minor/style comments. I'll let the rest of the team to chime in.

I guess this shouldn't be a blocker for moving the PR forward but can we test some of the code? I realize that it's tricky to do that for complex UI without getting into E2E but maybe we can do some unit testing of the more frictionless parts.

@milomg milomg requested a review from AleksanderBodurri June 9, 2025 15:28
cyber-hari
cyber-hari approved these changes Jun 14, 2025
View reviewed changes
Copy link

@cyber-hari cyber-hari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milomg
refactor(devtools): create devtools signals view
cc0f0ce 
create a component for the devtools signal pane, including view source, view value, and flashing of node updates
@milomg milomg added target: minor This PR is targeted for the next minor release action: merge The PR is ready for merge by the caretaker labels Jun 16, 2025
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 89efd27.

The changes were merged into the following branches: main

@milomg milomg deleted the signal-graph-8 branch June 17, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkgs hawkgs hawkgs left review comments

@michael-small michael-small michael-small left review comments

@msmallest msmallest msmallest left review comments

@JeanMeche JeanMeche JeanMeche approved these changes

@AleksanderBodurri AleksanderBodurri AleksanderBodurri approved these changes

@cyber-hari cyber-hari cyber-hari approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: devtools detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
8 participants
@milomg @hawkgs @pkozlowski-opensource @JeanMeche @michael-small @AleksanderBodurri @msmallest @cyber-hari