Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(core): drop injection context assertion in production #62038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(core): drop injection context assertion in production #62038

wants to merge 1 commit into from
+4 −1

Conversation

arturovt
Copy link
Contributor

Drops assertInInjectionContext call in production in afterNextRender.

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jun 12, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 12, 2025
JeanMeche
JeanMeche approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick check showed that this was the only callsite not guarded by ngDevMode.

@arturovt
refactor(core): drop injection context assertion in production
fb24a36 
Drops `assertInInjectionContext` call in production in `afterNextRender`.
@arturovt arturovt force-pushed the refactor/core-tree-shake-assert branch from 31e2553 to fb24a36 Compare June 18, 2025 23:24
@arturovt
Copy link
Contributor Author

@thePunderWoman cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@pkozlowski-opensource pkozlowski-opensource Awaiting requested review from pkozlowski-opensource

Assignees
No one assigned
Labels
area: core Issues related to the framework runtime
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@arturovt @JeanMeche