refactor(language-service): resolve module specifier for a directive … #62100
+512
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanwonder
commented
Jun 17, 2025
| importOn.getSourceFile(), | ||
| potentialImport.symbolName, | ||
| declarationName, | ||
| directiveModuleSpecifier?.moduleSpecifier ?? potentialImport.moduleSpecifier, |
There was a problem hiding this comment.
It's my mistake; the potentialImport can include multiple different module specifiers that export the directive and cannot be overridden directly. The code moves to the PotentialDirectiveModuleSpecifierResolverImpl.
atscott
approved these changes
Jun 18, 2025
bf83885 to
36a8919
Compare
…exported by multiple different files When providing the code action for the directive that is exported by multiple modules in different files, the directive must save all the TS completion entry data for every module to compute the module specifier. When providing a completion item, because the LS only supports displaying one directive at a time, the first one will be picked.
36a8919 to
8e754a9
Compare
ivanwonder
commented
Jun 21, 2025
Comment on lines
+750
to
+757
| /** | ||
| * Try to compute the module specifier after applying the paths from tsconfig or package.json export rules. | ||
| * | ||
| * Try to reuse the module specifier if the import in the `importOn` can export the `toImport` node. | ||
| * | ||
| * If a module specifier cannot be resolved, return undefined, and the Angular compiler will apply its own rules. | ||
| * | ||
| * There is one exception here. For example |
There was a problem hiding this comment.
Just comment out the main change in comparison to the previous version here. Even if an exception occurs, it will revert to the Angular compiler and keep the same behavior as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…exported by multiple different files
When providing the code action for the directive that is exported by multiple modules in different files, the directive must save all the TS completion entry data for every module to compute the module specifier.
When providing a completion item, because the LS only supports displaying one directive at a time, the first one will be picked.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information