Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(devtools): connect signal graph into directive explorer #62108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

milomg
Copy link
Contributor

@milomg milomg commented Jun 17, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

add an open signal graph button that can be enabled from devtools-tabs, display the signal graph in a split pane (however, both are hidden behind a signal that is currently always false)

See #60478 for a full demo

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: devtools labels Jun 17, 2025
@ngbot ngbot bot modified the milestone: Backlog Jun 17, 2025
@dgp1130
Copy link
Contributor

dgp1130 commented Jun 18, 2025

Minor nit: Let's use refactor in the commit message so this is hidden from release notes, since it's not user-visible on its own and not meaningful in the changelog as a result. The keystone PR can use feat, since that's when the feature will actually be made available.

@milomg
Copy link
Contributor Author

milomg commented Jun 18, 2025

Oops, forgot to reword this commit after rebasing it onto main. Thanks for the reminder!

@hawkgs hawkgs changed the title feat(devtools): connect signal graph into directive explorer refactor(devtools): connect signal graph into directive explorer Jun 18, 2025
add an open signal graph button that can be enabled from
devtools-tabs, display the signal graph in a split pane
@milomg milomg added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jun 18, 2025
@crisbeto
Copy link
Member

This PR was merged into the repository by commit 24d299e.

The changes were merged into the following branches: main

@crisbeto crisbeto closed this in 24d299e Jun 19, 2025
@milomg milomg deleted the signal-graph-9 branch June 20, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: devtools detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants