fix(core): fix "resource returned an error that's not an Error instance" for observables that produce HttpErrorResponse inside the rxResource signal #62110
Conversation
…ce" for observables that produce HttpErrorResponse inside the rxResource signal (angular#62099) (related to angular#61861)
| @@ -15,6 +15,7 @@ ng_project( | |||
| ), | |||
| interop_deps = [ | |||
| "//packages/core", | |||
| "//packages/common/http", | |||
There was a problem hiding this comment.
Dependency wise, the rxjs-interop should not depend on common/http.
| if (error instanceof HttpErrorResponse) { | ||
| return error; | ||
| } |
There was a problem hiding this comment.
This won't fix any other observable that throw an instance that isn't an error.
There was a problem hiding this comment.
@JeanMeche I'm aware of that, and I believe that's the point. error() signal returns value of type Error. Consider HttpErrorResponse to be a "built-in" type and should be fully supported, especially given that it implements the Error interface.
My PR addresses the issue for the observables produced by HttpClient, which, in my opinion, is a good step in improving the API.
To support all types of Errors, I believe the API should be rethought and might be addressed in further PRs upon agreeing on the details.
There was a problem hiding this comment.
I'll run some tests with #62111
|
Thanks for you're contribution, but we won't go with this change. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
RxResource signals were intended to work with the RxJs Observables.
Those are often encapsulated inside the service layer or produced as a by-product by the HttpClient.
Currently, rxResource throws an Error described in the issues below, even though HttpErrorResponse implements the Error interface.
This PR addresses the issue for the rxResource signals.
Issue Number: #62099, #61861
What is the new behavior?
No longer throws an error "Resource returned an error that's not an Error instance".
Successfully returns the intended value by error() signal.
Does this PR introduce a breaking change?
Other information