-
Notifications
You must be signed in to change notification settings - Fork 26.3k
fix(elements): return value on signal input getter #62113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chintankavathia
wants to merge
1
commit into
angular:main
Choose a base branch
from
chintankavathia:fix/element/signal/getter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(elements): return value on signal input getter #62113
chintankavathia
wants to merge
1
commit into
angular:main
from
chintankavathia:fix/element/signal/getter
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2eecaf1
to
d216d18
Compare
JoostK
reviewed
Jun 18, 2025
c63c5ac
to
06676ee
Compare
atscott
reviewed
Jun 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alxhub I think we would need to consider this a breaking change?
JoostK
reviewed
Jun 18, 2025
06676ee
to
39957d5
Compare
BREAKING CHANGE: Fix signal input getter behavior in custom elements. Before this change, signal inputs in custom elements required function calls to access their values (`elementRef.newInput()`), while decorator inputs were accessed directly (`elementRef.oldInput`). This inconsistency caused confusion and typing difficulties. The getter behavior has been standardized so signal inputs can now be accessed directly, matching the behavior of decorator inputs: Before: - Decorator Input: `elementRef.oldInput` - Signal Input: `elementRef.newInput()` After: - Decorator Input: `elementRef.oldInput` - Signal Input: `elementRef.newInput` closes angular#62097
39957d5
to
c83214b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: elements
Issues related to Angular Elements
breaking changes
detected: breaking change
PR contains a commit with a breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #62097
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #62097
What is the new behavior?
Does this PR introduce a breaking change?
Other information