docs: remove duplicate type casting in testing guide #62142
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
reviewed
Jun 19, 2025
Comment on lines
306
to
308
| private queryAll<T>(selector: string): T[] { | ||
| return harness.routeNativeElement!.querySelectorAll(selector) as any as T[]; | ||
| return harness.routeNativeElement!.querySelectorAll(selector) as T[]; | ||
| } |
There was a problem hiding this comment.
private queryAll<T extends Element>(selector: string): NodeListOf<T> {
return harness.routeNativeElement!.querySelectorAll(selector) as NodeListOf<T>;
}
Would be a correct typing here.
Currently your suggestion throws as querySelectorAll does not return an array.
There was a problem hiding this comment.
I have used it in my projects with T[] and it works without errors. How can I reproduce the error that is thrown in your case?
There was a problem hiding this comment.
I not exactly sure what your config is but I can reproduce it here
There was a problem hiding this comment.
I am using it in an application built with Angular 18.
There was a problem hiding this comment.
Well without a repro it's hard to understand what's happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information