docs(core): mark after{Next,Every}Render overloads as stable #62153
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your blog post signaled that afterNextRender and afterEveryRender are now stable: https://angular.love/angular-20-whats-new#Signal%20related%20APIs However, only 1 of the overloads of those was marked as stable. I detected this because angular-eslint errors on calls even to to the publicApi overload - and while that should probably be fixed on their end, your announcement wasn't specific about only one overload being stable, so I assume this was an oversight. angular-eslint related issue: angular-eslint/angular-eslint#2534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your blog post signaled that afterNextRender and afterEveryRender are now stable:
https://angular.love/angular-20-whats-new#Signal%20related%20APIs
However, only 1 of the overloads of those was marked as stable.
I detected this because angular-eslint errors on calls even to to the publicApi overload - and while that should probably be fixed on their end, your announcement wasn't specific about only one overload being stable, so I assume this was an oversight.
angular-eslint related issue:
angular-eslint/angular-eslint#2534
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The spec overloads of afterNextRender / afterEveryRender are marked as developer preview.
Issue Number: N/A
What is the new behavior?
They're marked as public APIs.
Does this PR introduce a breaking change?
Other information