fix(core): unable to retrieve defer blocks in tests when component injects ViewContainerRef #62156
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jects ViewContainerRef Fixes that `getDeferBlocks` wasn't accounting for the case where a component might be injecting `ViewContainerRef`. When that happens, an additional wrapper is introduced that needs to be accounted for when traversing the tree. Fixes angular#62047.
crisbeto
commented
Jun 20, 2025
| getDeferBlocks(lContainer[HOST], deferBlocks); | ||
| } | ||
|
|
||
| for (let j = CONTAINER_HEADER_OFFSET; j < lContainer.length; j++) { |
There was a problem hiding this comment.
This change is unrelated. I just renamed the i, because it was shadowing the i from the outer loop.
AndrewKushnir
approved these changes
Jun 20, 2025
|
(FYI, leaving it in the merge queue until Monday, since that might affect testing in g3 and may require attention/rollback) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that
getDeferBlockswasn't accounting for the case where a component might be injectingViewContainerRef. When that happens, an additional wrapper is introduced that needs to be accounted for when traversing the tree.Fixes #62047.