Consolidate compiler errors #62160
Open
Consolidate compiler errors #62160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have a `ParserError` that is used for the expression parser and a `ParseError` that is used everywhere else. These changes consolidate them into the `ParseError` to avoid confusion and make it easier to add more context in the future.
Removes the `_ControlFlowError`, because its name is confusing and it's just a wrapper around `TokenError`.
Replaces the `TokenError` class with `ParseError` to reduce the number of error classes we need to maintain.
Removes the `I18nError` class since it wasn't being used for anything aside from a wrapper.
Replaces the `TranslationParseError` with `ParseError` since it wasn't adding much on top of `ParseError`.
AndrewKushnir
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for more info, but the tl;dr is that these changes consolidate most of our compiler errors around
ParseErrorso that it's easier to add more context to it in a follow-up.