Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(common): feat interceptor accepts promise #62185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aparzi
Copy link
Contributor

@aparzi aparzi commented Jun 21, 2025

Feat #61451 - interceptor accepts promise

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Actual interceptor accept only Observable type

Issue Number: #61451

What is the new behavior?

Interceptor accept promise

Does this PR introduce a breaking change?

  • Yes
  • No

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: common Issues related to APIs in the @angular/common package labels Jun 21, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 21, 2025
@JeanMeche
Copy link
Member

Unfortunately this is too much of a breaking change and it's not worth landing when the current alternative (invoking from() in the interceptor itself) is very straight foward.
Also this doesn't bring us closer to dropping RxJS as it is still pretty much required in the typing/runtime.

@JeanMeche JeanMeche closed this Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: common Issues related to APIs in the @angular/common package detected: feature PR contains a feature commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants