fix(core): Fix animate.enter class removal when composing classes
#62981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc3c1c5 to
c3f5dd5
Compare
c3f5dd5 to
d9d7071
Compare
crisbeto
approved these changes
Aug 4, 2025
In the case when composing animation classes with `animate.enter` on the element itself and also with host bindings, the removal would only have context for one of the classes added: the last one added. This allows for tracking of the classes added by `animate.enter` via a WeakMap so we know the exact classes added and which to remove. Also shores up the tests to make sure we are fully testing animate.enter.
d9d7071 to
2a325f2
Compare
Member
|
This PR was merged into the repository by commit de3a0c5. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case when composing animation classes with
animate.enteron the element itself and also with host bindings, the removal would only have context for one of the classes added: the last one added. This allows for tracking of the classes added byanimate.entervia a WeakMap so we know the exact classes added and which to remove.Also shores up the tests to make sure we are fully testing
animate.enter.