-
Notifications
You must be signed in to change notification settings - Fork 26.6k
feat(core): Add migration for zoneless by default. #63042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
90bc0e6
to
33c9d17
Compare
2460337
to
0a396b7
Compare
4181cbd
to
c7000a1
Compare
c7000a1
to
8a5efe7
Compare
packages/core/schematics/migrations/bootstrap-options-migration/migration.ts
Show resolved
Hide resolved
packages/core/schematics/migrations/bootstrap-options-migration/migration.ts
Outdated
Show resolved
Hide resolved
packages/core/schematics/migrations/bootstrap-options-migration/migration.ts
Show resolved
Hide resolved
8a5efe7
to
59da345
Compare
packages/core/schematics/migrations/bootstrap-options-migration/migration.ts
Outdated
Show resolved
Hide resolved
59da345
to
e75eb74
Compare
12163c9
to
fa13492
Compare
1c8a29c
to
d34f38f
Compare
const ZONE_CD_PROVIDER = `${PROVIDE_ZONE_CHANGE_DETECTION}()`; | ||
|
||
const NoopNgZone = ` | ||
// TODO ADD WARNING MESSAGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @AndrewKushnir @jelbourn
You wanted to suggest a specifc error message here
packages/core/schematics/migrations/bootstrap-options-migration/migration.ts
Outdated
Show resolved
Hide resolved
13dd074
to
8e76ca4
Compare
This commit adds a migration that updates applications enable Zone change detection when Angular is zoneless by default.
8e76ca4
to
8ad0d2e
Compare
Marking this one as blocked, until the runtime changes have landed. |
@JeanMeche Removing the blocked label since this migration can go in first, as long as the other one does eventually land for v21 |
packages/core/schematics/migrations/bootstrap-options-migration/migration.spec.ts
Outdated
Show resolved
Hide resolved
packages/core/schematics/migrations/bootstrap-options-migration/migration.spec.ts
Show resolved
Hide resolved
packages/core/schematics/migrations/bootstrap-options-migration/migration.spec.ts
Outdated
Show resolved
Hide resolved
This PR was merged into the repository. The changes were merged into the following branches:
|
This migration moves the zone configuration from
bootstrapModule
/bootstrapApplication
to providers. This also include a migration forTestBed.initTestEnvironment
WIP