feat(compiler-cli): add check for numeric CSS properties requiring units #63705
+573
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: Add Numeric CSS Property Requires Unit Diagnostic
Overview
This PR introduces a new extended template diagnostic to Angular's compiler: NumericCssPropertyRequiresUnit. It warns developers when a numeric value is bound to a CSS property that requires a unit (e.g.,
[style.width]="500"
), which would have no effect in the browser. The diagnostic suggests using a unit suffix (e.g.,[style.width.px]="500"
or[style.width]="'500px'"
).Motivation
Binding numeric values to CSS properties without units is a common source of confusion and bugs. Browsers ignore such values, leading to unexpected UI behavior. This diagnostic helps developers catch these mistakes early and provides actionable suggestions.
Example
Diagnostic Message
Impact
[Related Issue]
#61381