Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(compiler-cli): signal not invoked diagnostic not raised when input has same name in template #63754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): signal not invoked diagnostic not raised when input has same name in template #63754

wants to merge 1 commit into from
+57 −5

Conversation

crisbeto
Copy link
Member

The diagnostic that flags signals which haven't been invoked has some logic to skip over inputs, however it was looking at the used directives across the entire template, not the ones on the specific node.

Fixes #63739.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 12, 2025
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Sep 12, 2025
@ngbot ngbot bot added this to the Backlog milestone Sep 12, 2025
@crisbeto
fix(compiler-cli): signal not invoked diagnostic not raised when inpu…
585c311 
…t has same name in template

The diagnostic that flags signals which haven't been invoked has some logic to skip over inputs, however it was looking at the used directives across the entire template, not the ones on the specific node.

Fixes angular#63739.
@crisbeto crisbeto force-pushed the 63739/invoked-diag-input branch from 31d7618 to 585c311 Compare September 12, 2025 14:57
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 14, 2025
thePunderWoman pushed a commit that referenced this pull request Sep 15, 2025
@crisbeto @thePunderWoman
fix(compiler-cli): signal not invoked diagnostic not raised when inpu…
38c9921 
…t has same name in template (#63754)

The diagnostic that flags signals which haven't been invoked has some logic to skip over inputs, however it was looking at the used directives across the entire template, not the ones on the specific node.

Fixes #63739.

PR Close #63754
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Importing and applying MatInput somehow disables an extended diagnostic on an unrelated signal
3 participants
@crisbeto @thePunderWoman @JeanMeche