feat(router): Expose wildcard segments as _splat param #64663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab5bad2 to
9b29372
Compare
BREAKING CHANGE: UrlMatchResult can now return UrlSegment[] for params. params can be spread across multiple segments. There is also a new _split param available for wildcard segments
9b29372 to
664ef71
Compare
Contributor
Author
|
Closing - rather than always doing this automatically with a special "splat" like tanstack does, which would be somewhat breaking, I think we could instead approach this with an "optional name" like solid has https://docs.solidjs.com/solid-router/concepts/catch-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: UrlMatchResult can now return UrlSegment[] for params.
params can be spread across multiple segments.
There is also a new _split param available for wildcard segments
first commit is in #64660