Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(compiler-cli): remove deep imports from compiler-cli #64732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(compiler-cli): remove deep imports from compiler-cli #64732

wants to merge 2 commits into from

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Oct 28, 2025

Accessed symbols are grouped into dedicated private entries

@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Oct 28, 2025
@ngbot ngbot bot added this to the Backlog milestone Oct 28, 2025
@JeanMeche JeanMeche force-pushed the compiler-cli-deep-imports branch 9 times, most recently from 4ee86cd to d9afbc3 Compare October 29, 2025 12:24
@JeanMeche JeanMeche marked this pull request as ready for review October 29, 2025 12:29
devversion
devversion approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! definitely time at some point to restrict visibility I think + maybe adjust the tsconfig path mappings so that IDEs don't generate such imports

@JeanMeche JeanMeche force-pushed the compiler-cli-deep-imports branch from d9afbc3 to bf11f86 Compare October 29, 2025 12:40
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Oct 29, 2025
alan-agius4
alan-agius4 approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as @devversion we should restrict visibility via bazel as otherwise it easy to regress.

@JeanMeche JeanMeche force-pushed the compiler-cli-deep-imports branch from fa705ba to 2ee934a Compare October 29, 2025 13:04
@JeanMeche
Copy link
Member Author

JeanMeche commented Oct 29, 2025

The second commit includes the visibility restrictions !

@JeanMeche JeanMeche force-pushed the compiler-cli-deep-imports branch from 2ee934a to 5eca147 Compare October 29, 2025 16:04
@JeanMeche JeanMeche force-pushed the compiler-cli-deep-imports branch from 5eca147 to a0e81e2 Compare October 29, 2025 23:31
@JeanMeche JeanMeche added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 30, 2025
@JeanMeche
Copy link
Member Author

JeanMeche commented Oct 30, 2025

caretaker note: CL to submit with this PR cl/825751016

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Oct 30, 2025
thePunderWoman pushed a commit that referenced this pull request Nov 6, 2025
@JeanMeche @thePunderWoman
refactor(compiler-cli): remove deep imports from compiler-cli (#64732)
af16b48 
Accessed symbols are grouped into dedicated `private` entries

PR Close #64732
thePunderWoman pushed a commit that referenced this pull request Nov 6, 2025
@JeanMeche @thePunderWoman
build: restrain visibility to compiler-cli subpackages (#64732)
acaa1e6 
This should solve future deep imports issues.

PR Close #64732
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Nov 6, 2025

This PR was merged into the repository. The changes were merged into the following branches:

thePunderWoman pushed a commit that referenced this pull request Nov 6, 2025
@JeanMeche @thePunderWoman
build: restrain visibility to compiler-cli subpackages (#64732)
70d8ed4 
This should solve future deep imports issues.

PR Close #64732
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Nov 6, 2025

This PR breaks G3 due to an incomplete patch CL. See https://fusion2.corp.google.com/presubmit/829052597/OCL:829052597:BASE:829070786:1762462343436:3bf5630;groups=PossiblyNewlyFailing/targets for more details.

@thePunderWoman thePunderWoman reopened this Nov 6, 2025
thePunderWoman added a commit to thePunderWoman/angular that referenced this pull request Nov 6, 2025
@thePunderWoman
Revert "refactor(compiler-cli): remove deep imports from `compiler-cl…
b629b8c 
…i` (angular#64732)"

This reverts commit 05938c1.
thePunderWoman added a commit to thePunderWoman/angular that referenced this pull request Nov 6, 2025
@thePunderWoman
Revert "build: restrain visibility to compiler-cli subpackages (angul…
ab91489 
…ar#64732)"

This reverts commit 70d8ed4.
thePunderWoman added a commit to thePunderWoman/angular that referenced this pull request Nov 6, 2025
@thePunderWoman
Revert "refactor(compiler-cli): remove deep imports from `compiler-cl…
cbb8544 
…i` (angular#64732)"

This reverts commit af16b48.
thePunderWoman added a commit to thePunderWoman/angular that referenced this pull request Nov 6, 2025
@thePunderWoman
Revert "build: restrain visibility to compiler-cli subpackages (angul…
559e4d6 
…ar#64732)"

This reverts commit acaa1e6.
thePunderWoman added a commit that referenced this pull request Nov 6, 2025
@thePunderWoman
Revert "refactor(compiler-cli): remove deep imports from `compiler-cl…
37092d0 
…i` (#64732)"

This reverts commit 05938c1.
thePunderWoman added a commit that referenced this pull request Nov 6, 2025
@thePunderWoman
Revert "build: restrain visibility to compiler-cli subpackages (#64732)"
6d1a978 
This reverts commit 70d8ed4.
thePunderWoman added a commit that referenced this pull request Nov 6, 2025
@thePunderWoman
Revert "refactor(compiler-cli): remove deep imports from `compiler-cl…
7c0daea 
…i` (#64732)"

This reverts commit af16b48.
thePunderWoman added a commit that referenced this pull request Nov 6, 2025
@thePunderWoman
Revert "build: restrain visibility to compiler-cli subpackages (#64732)"
dcfd7fe 
This reverts commit acaa1e6.
@thePunderWoman thePunderWoman added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Nov 6, 2025
@JeanMeche JeanMeche force-pushed the compiler-cli-deep-imports branch from a0e81e2 to 9a14c12 Compare November 8, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devversion devversion devversion approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees

No one assigned

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: build & ci Related the build and CI infrastructure of the project area: compiler Issues related to `ngc`, Angular's template compiler target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@JeanMeche @thePunderWoman @devversion @alan-agius4