fix(core): synchronize core sanitization schema with compiler - #68807
Closed
leonsenft wants to merge 2 commits into
Closed
fix(core): synchronize core sanitization schema with compiler#68807leonsenft wants to merge 2 commits into
leonsenft wants to merge 2 commits into
Conversation
angular#68689 recently updated the compiler schema which should be kept in sync with the core schema. Fix applied by running `pnpm bazel run //packages/core:dom_security_schema`.
atscott
approved these changes
May 19, 2026
josephperrott
approved these changes
May 19, 2026
josephperrott
left a comment
Member
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-security
AndrewKushnir
approved these changes
May 19, 2026
Removes the `should throw error on translated SVG script ResourceURL attributes` integration test from `security_integration_spec.ts`. This test is now obsolete because SVG `<script>` elements are stripped during template compilation (implemented in 90494cd). As a result, they are no longer present in the compiled template to trigger runtime sanitization, causing this test (which expected a sanitization error to be thrown) to fail.
Merged
Contributor
Author
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#68689 recently updated the compiler schema which should be kept in sync with the core schema. Fix applied by running
pnpm bazel run //packages/core:dom_security_schema.