Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(service-worker): preserve redirect policy on reconstructed asset requests - #68876

Merged
alxhub merged 2 commits into
angular:20.3.xfrom
alan-agius4:sw-fix-backport
May 27, 2026
Merged

fix(service-worker): preserve redirect policy on reconstructed asset requests#68876
alxhub merged 2 commits into
angular:20.3.xfrom
alan-agius4:sw-fix-backport

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented May 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Yenya030 added 2 commits May 22, 2026 07:32
@Yenya030 @alan-agius4
fix(service-worker): preserve redirect policy on reconstructed asset …
58532fe 
…requests

Preserve the redirect mode when rebuilding asset requests in newRequestWithMetadata(). This keeps explicit redirect:error semantics intact across service-worker redirect handling.

Update the worker test mocks to model redirect defaults correctly and add focused regression coverage for redirected lazy assets with redirect:error.
@Yenya030 @alan-agius4
refactor(service-worker): remove unnecessary cast in mock redirect check
1e0880a 
Use the typed Response.redirected property directly in the service-worker test mock instead of casting to any.
@alan-agius4 alan-agius4 added the target: lts This PR is targeting a version currently in long-term support label May 22, 2026
@pullapprove
pullapprove Bot requested a review from kirjs May 22, 2026 07:35
@angular-robot angular-robot Bot added the area: service-worker Issues related to the @angular/service-worker package label May 22, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 22, 2026
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 22, 2026
@alan-agius4
alan-agius4 requested review from JeanMeche and removed request for kirjs May 22, 2026 07:36
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 22, 2026
@alan-agius4

alan-agius4 commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

caretaker note: ignore the pending mergeability status since this is LTS.

@alan-agius4 alan-agius4 mentioned this pull request May 27, 2026
Merged
@alxhub
alxhub merged commit 9b5f8c2 into angular:20.3.x May 27, 2026
24 of 26 checks passed
@alxhub

alxhub commented May 27, 2026

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jun 27, 2026

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jun 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

@alxhub alxhub

Labels

action: merge The PR is ready for merge by the caretaker area: service-worker Issues related to the @angular/service-worker package merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: lts This PR is targeting a version currently in long-term support

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@alan-agius4 @alxhub @JeanMeche @Yenya030