Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[19.2.x] fix(service-worker): Preserves explicit 'credentials: omit' in asset requests - #68953

Merged
alxhub merged 2 commits into
angular:19.2.xfrom
alan-agius4:backport-68904-19.2.x
May 27, 2026
Merged

[19.2.x] fix(service-worker): Preserves explicit 'credentials: omit' in asset requests#68953
alxhub merged 2 commits into
angular:19.2.xfrom
alan-agius4:backport-68904-19.2.x

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented May 27, 2026

Copy link
Copy Markdown
Contributor

fix(service-worker): Preserves explicit 'credentials: omit' in asset requests

Ensures that explicitly provided credentials: 'omit' options are preserved
when creating new requests, preventing unintended credential inclusion.

fix(service-worker): Preserves HTTP cache mode in asset group requests

Ensures explicit HTTP cache mode from incoming requests is forwarded and maintained when creating fetch requests for assets, aligning with expected fetch behavior and preventing unintended cache handling.

Backport of #68904 to target 19.2.x.

@pullapprove
pullapprove Bot requested a review from devversion May 27, 2026 17:29
@angular-robot angular-robot Bot added the area: service-worker Issues related to the @angular/service-worker package label May 27, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 27, 2026
@alan-agius4
alan-agius4 requested review from AndrewKushnir and JeanMeche and removed request for devversion May 27, 2026 17:30
@alan-agius4 alan-agius4 added the target: lts This PR is targeting a version currently in long-term support label May 27, 2026
SkyZeroZx added 2 commits May 27, 2026 17:31
…requests

Ensures that explicitly provided `credentials: 'omit'` options are preserved
when creating new requests, preventing unintended credential inclusion.
Ensures explicit HTTP cache mode from incoming requests is forwarded and maintained when creating fetch requests for assets, aligning with expected fetch behavior and preventing unintended cache handling.
@alan-agius4
alan-agius4 force-pushed the backport-68904-19.2.x branch from 2a03a54 to 8a87ab8 Compare May 27, 2026 17:32
@alan-agius4
alan-agius4 removed the request for review from JeanMeche May 27, 2026 17:33
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 27, 2026
@alxhub
alxhub merged commit 5619120 into angular:19.2.x May 27, 2026
18 of 20 checks passed
@alxhub

alxhub commented May 27, 2026

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4
alan-agius4 deleted the backport-68904-19.2.x branch May 27, 2026 18:18
@angular-automatic-lock-bot

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jun 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: service-worker Issues related to the @angular/service-worker package target: lts This PR is targeting a version currently in long-term support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants