fix(common): Limits date format string length - #69000
Merged
Merged
Conversation
SkyZeroZx
marked this pull request as ready for review
May 28, 2026 19:58
JeanMeche
reviewed
May 28, 2026
alan-agius4
requested changes
May 29, 2026
alan-agius4
left a comment
Contributor
There was a problem hiding this comment.
Let's avoid introducing new error codes unless there's a strict requirement for it. We should reuse SUSPICIOUS_DATE_FORMAT here instead of adding a new variant.
JeanMeche
reviewed
May 30, 2026
Introduces a maximum length of 256 characters for date format strings. This prevents potential Denial of Service (DoS) attacks by throwing an `INVALID_DATE_FORMAT` error if an excessively long format string is provided to `formatDate` or `DatePipe`, safeguarding against performance degradation or application crashes.
JeanMeche
approved these changes
Jun 1, 2026
Contributor
Author
|
I think it would be ready to merge? That way I could also generate a backport for this case. |
Contributor
This was referenced Jun 5, 2026
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a maximum length of 256 characters for date format strings.
This prevents potential Denial of Service (DoS) attacks by throwing an
INVALID_DATE_FORMATerror if an excessively long format string is provided toformatDateorDatePipe, safeguarding against performance degradation or application crashes.This can be considered similar to #68840