Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[20.3.x] fix(core): harden TransferState restoration against DOM clobbering #69080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pkozlowski-opensource merged 1 commit into from
Jun 2, 2026
Merged

[20.3.x] fix(core): harden TransferState restoration against DOM clobbering #69080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/transfer_state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export function retrieveTransferredState(
// Locate the script tag with the JSON data transferred from the server.
// The id of the script tag is set to the Angular appId + 'state'.
const script = doc.getElementById(appId + '-state');
if (script?.textContent) {
if (script?.tagName === 'SCRIPT' && script.textContent) {
try {
// Avoid using any here as it triggers lint errors in google3 (any is not allowed).
// Decoding of `<` is done of the box by browsers and node.js, same behaviour as G3
Expand Down
24 changes: 23 additions & 1 deletion packages/core/test/transfer_state_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ import {getDocument} from '../src/render3/interfaces/document';
import {makeStateKey, TransferState} from '../src/transfer_state';

function removeScriptTag(doc: Document, id: string) {
doc.getElementById(id)?.remove();
let node = doc.getElementById(id);
while (node) {
node.remove();
node = doc.getElementById(id);
}
}

function addScriptTag(doc: Document, appId: string, data: object | string) {
Expand Down Expand Up @@ -57,6 +61,24 @@ describe('TransferState', () => {
expect(transferState.get(TEST_KEY, 0)).toBe(10);
});

it('ignores non-script elements that clobber the transfer state id', () => {
const id = APP_ID + '-state';

const clobberingNode = doc.createElement('div');
clobberingNode.id = id;
clobberingNode.textContent = '{"test":999}';
doc.body.appendChild(clobberingNode);

const script = doc.createElement('script');
script.id = id;
script.setAttribute('type', 'application/json');
script.textContent = '{"test":10}';
doc.body.appendChild(script);

const transferState: TransferState = TestBed.inject(TransferState);
expect(transferState.get(TEST_KEY, 0)).toBe(0);
});

it('is initialized to empty state if script tag not found', () => {
const transferState: TransferState = TestBed.inject(TransferState);
expect(transferState.get(TEST_KEY, 0)).toBe(0);
Expand Down
Loading