Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(http) : set response.ok based on given status code #8056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(http) : set response.ok based on given status code #8056

wants to merge 1 commit into from

Conversation

nexus-uw
Copy link

@nexus-uw nexus-uw commented Apr 13, 2016 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix
  • What is the current behavior? (You can also link to an open issue here)
    response.ok is not defined
  • What is the new behavior (if this is a feature change)?
    response.ok is set to true if status is 200-299 (as already documented)

closes #6503

mhevery
mhevery reviewed Apr 17, 2016
View reviewed changes
modules/angular2/src/http/static_response.ts
@@ -76,6 +76,7 @@ export class Response {
constructor(responseOptions: ResponseOptions) {
this._body = responseOptions.body;
this.status = responseOptions.status;
this.ok = (this.status >= 200 && this.status <= 299);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think success would be a better field name.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhevery , I am in agreement with you on this but the spec for fetch's response object has it defined as ok (ref: https://developer.mozilla.org/en-US/docs/Web/API/Response/ok, https://github.com/nexus-uw/angular/blob/http/fix-ok/modules/angular2/src/http/static_response.ts#L21-L25).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's follow the spec.

@mhevery
Copy link
Contributor

mhevery commented Apr 17, 2016

Please address the comment. looks good otherwise.

@mhevery mhevery added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 17, 2016
@mary-poppins
Copy link

Merging PR #8056 on behalf of @robertmesserle to branch presubmit-robertmesserle-pr-8056.

@mhevery mhevery closed this in 30c4352 Apr 20, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nexus-uw @mhevery @mary-poppins @robertmesserle @googlebot