build: improve globbing of jasmine test files #30470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
approved these changes
Jun 5, 2025
alan-agius4
reviewed
Jun 5, 2025
f2dc2fb to
e5d724c
Compare
This doesn't seem to surface here, but in the framework and in the COMP repo, the glob wasn't catching all files because it wasn't escpaed— so didn't actually get picked up by Jasmine, but was expanded by Bash. This improves this and makes this logic more future-proof.
e5d724c to
2e3708e
Compare
alan-agius4
approved these changes
Jun 5, 2025
|
The changes were merged into the following branches: main, 20.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't seem to surface here, but in the framework and in the COMP repo, the glob wasn't catching all files because it wasn't escaped— so didn't actually get picked up by Jasmine, but was expanded by Bash.
This improves the rule and makes this logic more future-proof.