Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: update 18.2.12 #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 20, 2024
Merged

fix: update 18.2.12 #989

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b296c25
fix: update origin
lacolaco Nov 20, 2024
7f0a1e4
fix: migrate tutorial
lacolaco Nov 20, 2024
e906eb6
fix: migrate reference contents
lacolaco Nov 20, 2024
0c1ea69
fix: migrate guide contents
lacolaco Nov 20, 2024
a02aa77
fix: update top-level banner patch
lacolaco Nov 20, 2024
c64a277
fix: address lint errors
lacolaco Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: update top-level banner patch
  • Loading branch information
@lacolaco
lacolaco committed Nov 20, 2024
commit a02aa77a87360081c49bfae9cc4e79df9eda42b5
4 changes: 2 additions & 2 deletions adev-ja/src/app/features/update/recommendations.en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2258,9 +2258,9 @@ export const RECOMMENDATIONS: Step[] = [
possibleIn: 1800,
necessaryAsOf: 1800,
level: ApplicationComplexity.Medium,
step: '18.0.0. Opt-out of caching for HTTP requests with auth headers',
step: '18.0.0. Opt-in of caching for HTTP requests with auth headers',
action:
'Use `includeRequestsWithAuthHeaders: true` in `withHttpTransferCache` to opt-out of caching for HTTP requests that require authorization.',
'Use `includeRequestsWithAuthHeaders: true` in `withHttpTransferCache` to opt-in of caching for HTTP requests that require authorization.',
},
{
possibleIn: 1800,
Expand Down
6 changes: 4 additions & 2 deletions adev-ja/src/app/sub-navigation-data.en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {NavigationItem} from '@angular/docs';
// These 2 imports are expected to be red because they are generated a build time
import FIRST_APP_TUTORIAL_NAV_DATA from '../../src/assets/tutorials/first-app/routes.json';
import LEARN_ANGULAR_TUTORIAL_NAV_DATA from '../../src/assets/tutorials/learn-angular/routes.json';
import DEFERRABLE_VIEWS_TUTORIAL_NAV_DATA from '../../src/assets/tutorials/deferrable-views/routes.json';

import {DefaultPage} from './core/enums/pages';
import {getApiNavigationItems} from './features/references/helpers/manifest.helper';
Expand Down Expand Up @@ -872,6 +873,7 @@ const DOCS_SUB_NAVIGATION_DATA: NavigationItem[] = [
export const TUTORIALS_SUB_NAVIGATION_DATA: NavigationItem[] = [
FIRST_APP_TUTORIAL_NAV_DATA,
LEARN_ANGULAR_TUTORIAL_NAV_DATA,
DEFERRABLE_VIEWS_TUTORIAL_NAV_DATA,
{
path: DefaultPage.TUTORIALS,
contentPath: 'tutorials/home',
Expand Down Expand Up @@ -948,7 +950,7 @@ const REFERENCE_SUB_NAVIGATION_DATA: NavigationItem[] = [
path: 'cli/cache',
},
{
label: 'clear',
label: 'clean',
path: 'cli/cache/clean',
},
{
Expand Down Expand Up @@ -1219,7 +1221,7 @@ const REFERENCE_SUB_NAVIGATION_DATA: NavigationItem[] = [
contentPath: 'reference/errors/NG0507',
},
{
label: 'NG0602: HTML content was altered after server-side rendering',
label: 'NG0602: Disallowed function call inside reactive context',
path: 'errors/NG0602',
contentPath: 'reference/errors/NG0602',
},
Expand Down
12 changes: 0 additions & 12 deletions tools/adev-patches/translate-2024-survey-banner.patch
View file
Open in desktop

This file was deleted.

12 changes: 12 additions & 0 deletions tools/adev-patches/translate-top-level-banner.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/adev/src/app/app.component.html b/adev/src/app/app.component.html
index 07ffbaf51b..19e4798fac 100644
--- a/adev/src/app/app.component.html
+++ b/adev/src/app/app.component.html
@@ -1,6 +1,6 @@
@defer (when isBrowser) {
<adev-progress-bar />
- <docs-top-level-banner expiry="2024-12-06" id="state-of-js-2024" link="https://survey.devographics.com/en-US/survey/state-of-js/2024?source=angular_homepage" text="Share your experience with Angular in The State of JavaScript 2024 survey" />
+ <docs-top-level-banner expiry="2024-12-06" id="state-of-js-2024" link="https://survey.devographics.com/en-US/survey/state-of-js/2024?source=angular_homepage" text="State of JavaScript 2024 アンケートであなたの経験を共有しましょう!" />
}
<button (click)="focusFirstHeading()" class="adev-skip">Skip to main content</button>