This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngRoute): dont duplicate optional params into query #10689
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling updateParams with properties which were optional, but
previously undefined, they would be duplicated into the query params as
well as into the path.
jsfiddle reproduction
From
#updateParams
docs:In the actual implementation of updateParams the "remaining properties" are determined prior to interpolation by checking if the
pathParam
for the givenkey
has a value; however, optional parameters may not exist inpathParams
.Alternative fixes might include
interpolate
before separatingsearchParams
, since it will remove matched keys from the passed innewParams
object.pathParams
object (switchRouteMatcher L536,if (key && val)
->if(key)
) and then check for the property as opposed to truthiness