This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngSanitize): use the smallest match on searching end tags #11443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngSanitize searches the string of the end tag with the longest match. So it removes all of the HTML strings between script elements. We should use the smallest possible match. Closes #11442
|
This should be fixed by #11790 |
mhevery
added a commit
to mhevery/angular.js
that referenced
this pull request
May 6, 2015
This implementation is based on inert document Closes angular#11442 Closes angular#11443
mhevery
added a commit
to mhevery/angular.js
that referenced
this pull request
May 6, 2015
This implementation is based on inert document Closes angular#11442 Closes angular#11443
mhevery
added a commit
to mhevery/angular.js
that referenced
this pull request
May 6, 2015
This implementation is based on inert document Closes angular#11442 Closes angular#11443
mhevery
added a commit
to mhevery/angular.js
that referenced
this pull request
May 6, 2015
This implementation is based on inert document Closes angular#11442 Closes angular#11443
mhevery
added a commit
to mhevery/angular.js
that referenced
this pull request
May 7, 2015
This implementation is based on inert document Closes angular#11442 Closes angular#11443
mhevery
added a commit
to mhevery/angular.js
that referenced
this pull request
May 14, 2015
This implementation is based on inert document Closes angular#11442 Closes angular#11443
lgalfaso
pushed a commit
to lgalfaso/angular.js
that referenced
this pull request
Jul 31, 2015
This implementation is based on inert document Closes angular#11442 Closes angular#11443
|
Closing this in favor of #11790 |
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this pull request
Aug 7, 2015
This implementation is based on inert document Closes angular#11442 Closes angular#11443
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this pull request
Sep 8, 2015
This implementation is based on using inert document parsed by the browser Closes angular#11442 Closes angular#11443
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this pull request
Sep 8, 2015
This implementation is based on using inert document parsed by the browser Closes angular#11442 Closes angular#11443
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this pull request
Sep 9, 2015
This implementation is based on using inert document parsed by the browser Closes angular#11442 Closes angular#11443
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this pull request
Sep 11, 2015
This implementation is based on using inert document parsed by the browser Closes angular#11442 Closes angular#11443
ggershoni
pushed a commit
to ggershoni/angular.js
that referenced
this pull request
Sep 29, 2015
This implementation is based on inert document Closes angular#11442 Closes angular#11443
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngSanitize searches the string of the end tag with the longest match.
So it removes all of the HTML strings between script elements.
We should use the smallest possible match.
Closes #11442