Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor(jQlite): Add the ability to use query selector without jQuery #15986

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor(jQlite): Add the ability to use query selector without jQuery #15986

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
930ee2d
refactor(jQlite): add the ability to use query selector without jQuery
orafaelfragoso May 14, 2017
ecb0569
refactor(jQuery): call window before using document
Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor(jQuery): call window before using document 
use the window to call document as instructed
  • Loading branch information
Rafael Fragoso committed Oct 11, 2017
commit ecb0569ad1fa143117751f1b2b3147fdd8880ec6
2 changes: 1 addition & 1 deletion src/jqLite.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ function JQLite(element) {
}
if (!(this instanceof JQLite)) {
if (argIsString && element.charAt(0) !== '<') {
return new JQLite(document.querySelector(element));
return new JQLite(window.document.querySelector(element));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good place to add this logic as it'd mean new angular.element(selector) wouldn't work. This whole if should just be removed and the logic should me moved down.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, note it should use querySelectorAll, not querySelector as we want to select all matching elements, not one.

}
return new JQLite(element);
}
Expand Down