docs(isolateScope): update guide to reflect usage of element.isolateScope #5329
Conversation
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
the CLA has been signed with "Tobias Gesellchen". |
| @@ -344,6 +344,7 @@ element as a customer component. | |||
|
|
|||
|
|
|||
| ### Isolating the Scope of a Directive | |||
| <a name="isolated_scope"></a> | |||
There was a problem hiding this comment.
This is the anchor referenced from scope.ngdoc. Do you know of better ways for cross page linking?
There was a problem hiding this comment.
We automatically generate ids on headings, so this is not needed. The URL to this heading is
http://docs.angularjs.org/guide/directive#creating-custom-directives_demo_isolating-the-scope-of-a-directive
…cope() update developer guide for scope and directives to reflect the changes of angular@27e9340 introducing `element.isolateScope()` Closes angular#5274
replace detailed text on usage of isolateScope with a link the API docs
| @@ -506,7 +507,7 @@ that you explicitly pass in. | |||
|
|
|||
| <div class="alert alert-warning"> | |||
| **Note:** Normally, a scope prototypically inherits from its parent. An isolated scope does not. | |||
| </div> | |||
| See the {@link api/angular.element element API} for details.</div> | |||
There was a problem hiding this comment.
We generate links to code automatically from the code name so this should simply be: {@link angular.element element API}
There was a problem hiding this comment.
Woh, hold on. What is the point of this link? angular.element has nothing to say about isolated scopes. I guess you meant to put a link back to the "Isolating the scope of a directive" section?
There was a problem hiding this comment.
I think I originally said that it would be good to refer to angular.element to explain the isolateScope() helper, but the comments regarding that seem to have been removed. Unless that was a different issue. And the surrounding text seems to have changed
|
thanks for your help! |
update developer guide for scope and directives to reflect the changes of 27e9340 introducing
element.isolateScope()Closes #5274