Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngForm): 2513 ngForm triggers click/submit events like normal form #6704

Closed
wants to merge 4 commits into from
Closed

fix(ngForm): 2513 ngForm triggers click/submit events like normal form #6704

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04be9fb
Fixed ng-form so that it triggers submit and click events like a norm…
andytompkins Mar 16, 2014
d5e497a
Fixed indentation
andytompkins Mar 16, 2014
2a02a4a
Added button elements to the list of things which can trigger submit
andytompkins Mar 16, 2014
242f160
Fixing indentation and spacing problems
andytompkins Mar 17, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions src/ng/directive/form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,69 @@ var formDirectiveFactory = function(isNgForm) {
extend(controller, nullFormCtrl); //stop propagating child destruction handlers upwards
});
}

if (isNgForm) {
var buttons = [],
submits = [],
others = [];
var inputs = formElement[0].querySelectorAll('input, button');
for (var i = 0; i < inputs.length; i++) {
var elem = angular.element(inputs[i]);
var elemType = elem.attr('type');
if (elemType) {
if ('button' === elemType.toLowerCase()) {
buttons.push(elem);
} else if ('submit' === elemType.toLowerCase()) {
submits.push(elem);
} else {
others.push(elem);
}
} else {
others.push(elem);
}
}

var submitElem = null;
if (submits.length) {
submitElem = submits[0];
} else if (buttons.length) {
submitElem = buttons[0];
}

if (submitElem) {
addEventListenerFn(submitElem[0], 'click', function(event) {
formElement.triggerHandler('submit');
});
}

if (inputs.length === 1) {
/*
* - If a form has only one input field then hitting enter in this field triggers form submit
* (`ngSubmit`)
*/
var singleInput = angular.element(inputs[0]);
addEventListenerFn(singleInput[0], 'keyup', function(event) {
if (event.which === 13) {
formElement.triggerHandler('submit');
}
});
} else if (others.length && (buttons.length + submits.length)) {
/*
* - if a form has one or more input fields and one or more buttons or input[type=submit] then
* hitting enter in any of the input fields will trigger the click handler on the *first* button or
* input[type=submit] (`ngClick`) *and* a submit handler on the enclosing form (`ngSubmit`)
*/
for (i = 0; i < others.length; i++) {
var otherElem = others[i];
addEventListenerFn(otherElem[0], 'keyup', function(event) {
if (event.which === 13) {
submitElem.triggerHandler('click');
formElement.triggerHandler('submit');
}
});
}
}
}
}
};
}
Expand Down