This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Some small doc updates #7002
Closed
Some small doc updates #7002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc now shows newCard.id is set only after the server responds, since we should only `expect(newCard.id).toEqual(789)` after the promise is resolved.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| // POST: /user/123/card {number:'0123', name:'Mike Smith'} | ||
| // server returns: {id:789, number:'0123', name: 'Mike Smith'}; | ||
| expect(newCard.id).toEqual(789); | ||
| newCard.$save().then(function() { |
There was a problem hiding this comment.
This is wrong, instance actions won't create a new promise (it will still have the old promise), so this wouldn't wait for a response from the server, just the next tick.
caitp
pushed a commit
that referenced
this pull request
Apr 5, 2014
"submitting and issue" should be "submitting an issue" Closes #7002
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm new enough to angular that I'm not positive I got the $save().then() example right, so I would appreciate a second pair of eyes.