docs($cacheFactory): prevent example breaking on key update #8214
Conversation
The example for $cacheFactory breaks when a user tries to update a value for a key. Setting a new value for an existing key results in duplicate key entries in the key array, thus breaking the ng-repeat directive. With this fix the key is only added if it isn't contained in the array already.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
Has this dropped from the radar due to the build error? The build error isn't related to the PR, but sadly I cannot restart it to get rid of it. |
|
Nah, don't worry about the build error kasoban --- if you want to restart it you can just force-push to your branch, too (the real reason is honestly that there are so many PRs and issues, there are about 50 untraiged issues/PRs and some of them are a bit more demanding of attention/take longer) |
|
So the issue here is the track by issue... but I think we can fix this in a more algorithmically efficient way. I'll make a slight modification and check this in |
The example for $cacheFactory breaks when a user tries to update a value for a key. Setting a new value for an existing key results in duplicate key entries in the key array, thus breaking the ng-repeat directive. With this fix the key is only added if it isn't contained in the cache. Closes #8214
The example for $cacheFactory breaks when a user tries to update a value for a key.
Setting a new value for an existing key results in duplicate key entries in the key array, thus breaking the ng-repeat directive.
With this fix the key is only added if it isn't contained in the array already.