Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

• Uses the issue template (#8255)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

The docs are generated by angular/dgeni.
@petebacondarwin Can you help with the ng-app problem?

I am sure there is an option to turn it off
On 18 Jul 2014 17:01, "Narretz" [email protected] wrote:

The docs are generated by angular/dgeni.
@petebacondarwin https://github.com/petebacondarwin Can you help with
the ng-app problem?

—
Reply to this email directly or view it on GitHub
#8255 (comment).

Use ng-app-included as an attribute on the example tag

See

Ah oke thanks (should have read the docs better, sr about that). I'll update the PR.

Thanks for this @vdyckn - this is a complex example, eh?
I think it would be easier to follow and maintain if we were to create two different examples, one displaying each form of URL mapping. What do you think? Then we wouldn't have to do quite so much layering.

How about a pair of examples like this: http://plnkr.co/edit/KZXbUVRNYuwf0E7sh7j4?p=preview

Yeah it's too complex to keep in the docs. I was also thinking about changing and simplifying the example, but chose to not change the example too much.

@petebacondarwin : the example looks nice. I'll update the PR and split up the examples. (although i think the directive isn't working, but i'll fix it)

I'll also add some ptor tests

Great!

Examples are split up, but didn't have time today to write test. Will do that tommorow.

@petebacondarwin was this what you meant with splitting up these examples?

Yes like that! Some tests would be great then we could merge.

Okay finally found some time to write the tests.

But i got a problem with these tests. If i don't (browser.ignoreSynchronization = true;) before each it statement, i get the following error.

Error: Error while waiting for Protractor to sync with the page: {}

Am I doing something wrong in the code here?

I'll take a look tomorrow. It might be that Protractor is struggling to find the angular app in the page, since we are hacking the $browser.

Yes: https://github.com/angular/protractor/blob/bf26f76ba5dc99d02ea4cd7fc198dce410a9f58c/lib/clientsidescripts.js#L32

We should use a decorator for $browser and pass through this call.

I'll fix this up and merge in

Ok nice, looking forward to see the result. Let me know if you need some extra hands.