Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngSwitch attemps to remove DOM elements twice due to async iteration #8833

Closed
wants to merge 7 commits into from
Closed

ngSwitch attemps to remove DOM elements twice due to async iteration #8833

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e12e5bb
done
thebigredgeek Aug 29, 2014
d366639
the right way to remove elements and splice from array
thebigredgeek Aug 29, 2014
fbd8f7e
oops!
thebigredgeek Aug 29, 2014
99c17ca
fix
thebigredgeek Aug 29, 2014
5a04052
patched potential leak by wrapping callback in a closure to deference…
thebigredgeek Aug 30, 2014
2c1bc3d
chore(ngSwitch): remove change attribute and update spec
thebigredgeek Aug 30, 2014
0e322a8
chore(ngSwitch): remove change attribute and update spec
thebigredgeek Aug 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
the right way to remove elements and splice from array
  • Loading branch information
@thebigredgeek
thebigredgeek committed Aug 29, 2014
commit d36663950253d38863d8b98a012014af2c2ce903
13 changes: 5 additions & 8 deletions src/ng/directive/ngSwitch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,18 +146,15 @@ var ngSwitchDirective = ['$animate', function($animate) {

scope.$watch(watchExpr, function ngSwitchWatchAction(value) {
var i, ii;
for (i = 0, ii = previousElements.length; i < ii; ++i) {
previousElements[i].remove();
}
previousElements.length = 0;

for (i = 0, ii = selectedScopes.length; i < ii; ++i) {
var selected = getBlockNodes(selectedElements[i].clone);
selectedScopes[i].$destroy();
previousElements[i] = selected;
$animate.leave(selected).then(function() {
previousElements[i] ? previousElements.splice(i, 1) : angular.noop();
});
$animate.leave(selected).then((function(i) {
return function(){
previousElements.splice(i, 1).remove();
};
}(i));
}

selectedElements.length = 0;
Expand Down