Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(schematics): support FIREBASE_TOKEN for ng deploy - #2327

Merged
jamesdaniels merged 8 commits into
angular:masterfrom
IKatsuba:firebase-token-from-env
Nov 11, 2020
Merged

feat(schematics): support FIREBASE_TOKEN for ng deploy#2327
jamesdaniels merged 8 commits into
angular:masterfrom
IKatsuba:firebase-token-from-env

Conversation

@IKatsuba

Copy link
Copy Markdown
Contributor

Checklist

Description

Code sample

@IKatsuba

IKatsuba commented Mar 3, 2020

Copy link
Copy Markdown
Contributor Author

Any updates?

@IKatsuba

Copy link
Copy Markdown
Contributor Author

@jamesdaniels hello! I really need this feature. Can you give comments on it?

@jamesdaniels jamesdaniels added this to the 6.0.0 milestone Mar 27, 2020
@jamesdaniels

Copy link
Copy Markdown
Contributor

We'll get this in shortly, thanks for the contribution.

…-env

# Conflicts:
#	src/schematics/deploy/actions.jasmine.ts
#	src/schematics/deploy/actions.ts
#	src/schematics/deploy/builder.ts
@wajeehmisbahkhan

Copy link
Copy Markdown

Please provide updates on this or at least an alternative on how to use the firebase token in a CI environment. I tried deploying in Github Actions with

env:
  FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}

And I get:
Cannot run login in non-interactive mode. See login:ci to generate a token for use in non-interactive environments.

How do I set the environment variable so that it doesn't require a login?

@IKatsuba

IKatsuba commented Jun 8, 2020

Copy link
Copy Markdown
Contributor Author

@wajeehmisbahkhan I tried to update the request, but the team never looked at it. Maybe @jamesdaniels have a different plan. Now I have no time to support this PR.

@jamesdaniels jamesdaniels modified the milestones: 6.0.0, 6.1 Jun 23, 2020
@jamesdaniels

Copy link
Copy Markdown
Contributor

I can take this to the finish line before I cut 6.1, thanks @IKatsuba

@IKatsuba

Copy link
Copy Markdown
Contributor Author

@wajeehmisbahkhan you can try this package @ng-builders/firebase

@jamesdaniels
jamesdaniels merged commit dd92869 into angular:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants