fix(material/datepicker): prevent calendar from stealing away focus #31128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An earlier change added some logic to the calendar to re-focus the active date if an input requiring a full re-render changes which can potentially cause focus to be lost. The problem with this is that if the calendar is used on its own, it might steal away focus even though the user wasn't interacting with it. These changes add a check that focus is inside the calendar before attempting to recapture it. Fixes angular#30635.
andrewseguin
approved these changes
May 15, 2025
|
The changes were merged into the following branches: main, 19.2.x, 20.0.x |
crisbeto
added a commit
that referenced
this pull request
May 15, 2025
…31128) An earlier change added some logic to the calendar to re-focus the active date if an input requiring a full re-render changes which can potentially cause focus to be lost. The problem with this is that if the calendar is used on its own, it might steal away focus even though the user wasn't interacting with it. These changes add a check that focus is inside the calendar before attempting to recapture it. Fixes #30635. (cherry picked from commit 5397b38)
crisbeto
added a commit
that referenced
this pull request
May 15, 2025
…31128) An earlier change added some logic to the calendar to re-focus the active date if an input requiring a full re-render changes which can potentially cause focus to be lost. The problem with this is that if the calendar is used on its own, it might steal away focus even though the user wasn't interacting with it. These changes add a check that focus is inside the calendar before attempting to recapture it. Fixes #30635. (cherry picked from commit 5397b38)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier change added some logic to the calendar to re-focus the active date if an input requiring a full re-render changes which can potentially cause focus to be lost.
The problem with this is that if the calendar is used on its own, it might steal away focus even though the user wasn't interacting with it.
These changes add a check that focus is inside the calendar before attempting to recapture it.
Fixes #30635.