-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(cdk-experimental/accordion): add accordion directives, example, and tests #31134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deployed dev-app for 1f2ebfc to: https://ng-dev-previews-comp--pr-angular-components-31134-dev-pemcmxw4.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
d112ad0
to
a9a1651
Compare
In the demo I see that if I:
It toggles item 2 closed even though item 2's trigger is disabled. Is that the correct behavior? (genuinely not sure). I think it feels odd to me because the intent of the disabled trigger is like "hey user, you can't change this", but then if they toggle a different item they actually can |
You are absolutely correct. Agree that the expansion state for a disabled trigger shouldn't be changed. Fixed in the Expansion behavior to ensure the disabled triggers are excluded from the state changes. |
No description provided.