Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add icon name filtering to MatButtonHarness #31852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add icon name filtering to MatButtonHarness #31852

wants to merge 2 commits into from
+17 −1

Conversation

wildcardalice
Copy link
Contributor

@wildcardalice wildcardalice commented Sep 11, 2025 •
edited
Loading

In its current implementation, icon buttons and FABs are more difficult to filter for compared to text-based buttons, which can use their { text} filter property, usually relying on a custom selector (eg: class or id) or ancestor. This change aims to simplify this by allowing a user to filter via a contained icon. The filtering logic is quite simple and reuses the existing logic inside MatIconHarness for simplicity and reliability.

Example usage:

const iconButton = await getHarness(MatButtonHarness.with({ icon: "favorite" }));

@wildcardalice wildcardalice requested a review from a team as a code owner September 11, 2025 20:33
@wildcardalice wildcardalice requested review from mmalerba and tjshiu and removed request for a team September 11, 2025 20:33
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: material/testing labels Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba mmalerba is a code owner automatically assigned from angular/components-googlers

@tjshiu tjshiu Awaiting requested review from tjshiu tjshiu is a code owner automatically assigned from angular/components-googlers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: material/testing detected: feature PR contains a feature commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wildcardalice