Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(eslint-plugin): update list of native events #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 16, 2024
Merged

fix(eslint-plugin): update list of native events #1881

merged 7 commits into from
Sep 16, 2024

Conversation

demkalkov
Copy link
Contributor

Update a list of native events.
Resolves issue #1671

@JamesHenry
Copy link
Member

@demkalkov Please can you cite the source for this hugely updated list?

The original comment by Rafael from several years ago does not seem to contain a straightforward list? It would definitely be good to make it clear where this data comes from

JamesHenry
JamesHenry requested changes Jun 30, 2024
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@demkalkov
Copy link
Contributor Author

@demkalkov Please can you cite the source for this hugely updated list?

The original comment by Rafael from several years ago does not seem to contain a straightforward list? It would definitely be good to make it clear where this data comes from

The list of events is taken from the MDN page specified in a file, but a French version of it. I've just started to update the English version, but it might take some time.

@demkalkov
Copy link
Contributor Author

See comment

done

@demkalkov demkalkov requested a review from JamesHenry July 8, 2024 09:46
@demkalkov demkalkov force-pushed the feature/update-native-event-names branch from 5833a5e to 5bc54d3 Compare July 28, 2024 16:42
@demkalkov demkalkov mentioned this pull request Jul 28, 2024
Closed
@JamesHenry JamesHenry changed the title chore: update list of native events fix(eslint-plugin): update list of native events Jul 31, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 31, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b13187d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@JamesHenry
Copy link
Member

Looks like this change causes the unit tests to fail, did you run them locally?

@JamesHenry
Copy link
Member

@demkalkov Following up on this one please

@demkalkov
Copy link
Contributor Author

@demkalkov Following up on this one please

updated and fixed the unit tests

@JamesHenry JamesHenry merged commit a27993e into angular-eslint:main Sep 16, 2024
7 checks passed
@JamesHenry
Copy link
Member

Thank you @demkalkov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
awaiting response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demkalkov @JamesHenry