Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: switch to using angular-devkit directly for schematics and builder #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

JamesHenry
Copy link
Member

No description provided.

Copy link

nx-cloud bot commented Aug 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 688557e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 76.05634% with 17 lines in your changes missing coverage. Please review.

Project coverage is 91.73%. Comparing base (7425423) to head (688557e).

Files Patch % Lines
packages/schematics/src/utils.ts 77.58% 6 Missing and 7 partials ⚠️
packages/builder/src/lint.impl.ts 25.00% 2 Missing and 1 partial ⚠️
...ages/schematics/src/add-eslint-to-project/index.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1985      +/-   ##
==========================================
- Coverage   91.73%   91.73%   -0.01%     
==========================================
  Files         182      181       -1     
  Lines        3401     3400       -1     
  Branches      555      552       -3     
==========================================
- Hits         3120     3119       -1     
- Misses        143      144       +1     
+ Partials      138      137       -1     
Flag Coverage Δ
unittest 91.73% <76.05%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/schematics/src/application/index.ts 88.88% <100.00%> (ø)
packages/schematics/src/library/index.ts 88.88% <100.00%> (ø)
...ages/schematics/src/add-eslint-to-project/index.ts 70.00% <66.66%> (+3.33%) ⬆️
packages/builder/src/lint.impl.ts 76.38% <25.00%> (-1.08%) ⬇️
packages/schematics/src/utils.ts 79.74% <77.58%> (+1.74%) ⬆️

... and 1 file with indirect coverage changes

@JamesHenry JamesHenry marked this pull request as ready for review August 13, 2024 11:30
@JamesHenry JamesHenry merged commit c5a70bb into main Aug 13, 2024
6 of 7 checks passed
@JamesHenry JamesHenry deleted the angular-devkit branch August 13, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant