Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: support ESM configs and .cjs and .mjs extensions #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2024
Merged

feat: support ESM configs and .cjs and .mjs extensions #2068

merged 3 commits into from
Oct 20, 2024

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Oct 15, 2024 •
edited
Loading

TODOs:

  • update schematics to detect if ESM should be used and generate relevant content instead of CJS
  • add e2e coverage for ESM and .cjs and .mjs file extensions

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 15, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e947e1b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@JamesHenry JamesHenry force-pushed the support-more-flat-config-files branch from e2d49a0 to df34653 Compare October 15, 2024 21:29
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.58621% with 13 lines in your changes missing coverage. Please review.

Project coverage is 91.51%. Comparing base (ad58694) to head (e947e1b).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
packages/schematics/src/utils.ts 73.33% 6 Missing and 6 partials ⚠️
packages/builder/src/utils/eslint-utils.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2068      +/-   ##
==========================================
- Coverage   91.73%   91.51%   -0.23%     
==========================================
  Files         181      181              
  Lines        3401     3453      +52     
  Branches      552      572      +20     
==========================================
+ Hits         3120     3160      +40     
- Misses        144      146       +2     
- Partials      137      147      +10
Flag Coverage Δ
unittest 91.51% <77.58%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/builder/src/lint.impl.ts 76.38% <100.00%> (ø)
packages/schematics/src/ng-add/index.ts 83.78% <100.00%> (+0.45%) ⬆️
packages/builder/src/utils/eslint-utils.ts 74.13% <80.00%> (+3.22%) ⬆️
packages/schematics/src/utils.ts 78.04% <73.33%> (-1.70%) ⬇️

@JamesHenry JamesHenry marked this pull request as ready for review October 20, 2024 19:27
@JamesHenry JamesHenry merged commit 2130596 into main Oct 20, 2024
12 of 13 checks passed
@JamesHenry JamesHenry deleted the support-more-flat-config-files branch October 20, 2024 19:28
@hakimio hakimio mentioned this pull request Dec 31, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JamesHenry